stevenzwu commented on code in PR #6184:
URL: https://github.com/apache/iceberg/pull/6184#discussion_r1022344797
##########
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##########
@@ -113,6 +114,9 @@ public FlinkCatalog(
asNamespaceCatalog =
originalCatalog instanceof SupportsNamespaces ? (SupportsNamespaces)
originalCatalog : null;
closeable = originalCatalog instanceof Closeable ? (Closeable)
originalCatalog : null;
+
+ EnvironmentContext.put(EnvironmentContext.ENGINE_NAME, "flink");
+ EnvironmentContext.put(EnvironmentContext.ENGINE_VERSION, "1.14");
Review Comment:
we probably need to figure out the programmatical way. otherwise, next time
when we add a new module like 1.17. This hard-coded value can easily be missed
and carried over.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
