Fokko opened a new pull request, #6197: URL: https://github.com/apache/iceberg/pull/6197
From https://github.com/apache/iceberg/pull/6141, for follow-up: > Fix types returned by to when AboveMax/BelowMin are returned Fixed - Add tests for binding with invalid conversions Added some tests to cover the last few uncovered lines: ``` poetry run coverage report -m --fail-under=90 Name Stmts Miss Cover Missing ------------------------------------------------------------------------ ... pyiceberg/expressions/literals.py 331 0 100% ``` - Update binding to rewrite expressions when AboveMax and BelowMin are returned First thing after https://github.com/apache/iceberg/pull/6139 has been merged - Check whether we need AboveMax/BelowMin for longs, since Python uses arbitrary precision numbers Do you mean when you run Python on a 32bit computer? This will reduce the precision. - Improve some of the error messages Went over all of them 👍🏻 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
