Fokko commented on code in PR #5338:
URL: https://github.com/apache/iceberg/pull/5338#discussion_r1025186972
##########
api/src/main/java/org/apache/iceberg/ManifestFile.java:
##########
@@ -52,11 +52,11 @@ public interface ManifestFile {
optional(
503, "added_snapshot_id", Types.LongType.get(), "Snapshot ID that
added the manifest");
Types.NestedField ADDED_FILES_COUNT =
- optional(504, "added_data_files_count", Types.IntegerType.get(), "Added
entry count");
+ optional(504, "added_files_count", Types.IntegerType.get(), "Added entry
count");
Types.NestedField EXISTING_FILES_COUNT =
- optional(505, "existing_data_files_count", Types.IntegerType.get(),
"Existing entry count");
+ optional(505, "existing_files_count", Types.IntegerType.get(), "Existing
entry count");
Types.NestedField DELETED_FILES_COUNT =
- optional(506, "deleted_data_files_count", Types.IntegerType.get(),
"Deleted entry count");
+ optional(506, "deleted_files_count", Types.IntegerType.get(), "Deleted
entry count");
Review Comment:
Hey @ajantha-bhat Thanks, that's actually a good point. However, If we go
that route, I'd prefer to do that separately because of two reasons:
- Looking at the code, I also see that we occasionally fetch the struct by
name.
- The code and spec are consistent, so we have to change them both
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
