szehon-ho commented on code in PR #6045:
URL: https://github.com/apache/iceberg/pull/6045#discussion_r1025379199
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -518,11 +541,26 @@ private Map<String, String> convertToMetadata(Database
database) {
if (database.getDescription() != null) {
meta.put("comment", database.getDescription());
}
+ if (database.getOwnerName() != null) {
+ meta.put(HMS_DB_OWNER, database.getOwnerName());
+ if (database.getOwnerType() != null) {
+ meta.put(HMS_DB_OWNER_TYPE, database.getOwnerType().name());
+ }
+ }
return meta;
}
Database convertToDatabase(Namespace namespace, Map<String, String> meta) {
+ Preconditions.checkArgument(
+ meta.get(HMS_DB_OWNER_TYPE) == null
Review Comment:
Optional: I actually think here there may not be such a need for this extra
bulky check, and call to a third party library? If I'm not mistaken the
valueOf anyway throws IllegalArgumentException if it does not match a value,
which would suffice for us? The only thing we dont get is maybe the valid
values, but I think the user can find that out kind of easily?
not sure if it throws exception for nulls, if not we could have a
Precondition for that only?
Just trying to reduce bulky code here if possible, and also avoid call to
third party library if there's no existing precedent and overwhelming need, as
that can make future upgrades kind of hard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
