Fokko commented on code in PR #6034:
URL: https://github.com/apache/iceberg/pull/6034#discussion_r1025571738
##########
python/pyiceberg/catalog/__init__.py:
##########
@@ -70,9 +81,19 @@ def load_hive(name: str, conf: Properties) -> Catalog:
raise NotInstalledError("Apache Hive support not installed: pip
install 'pyiceberg[hive]'") from exc
+def load_glue(name: str, conf: Properties) -> Catalog:
+ try:
+ from pyiceberg.catalog.glue import GlueCatalog
+
+ return GlueCatalog(name, **conf)
+ except ImportError as exc:
+ raise NotInstalledError("AWS glue support not installed: pip install
'pyiceberg[glue, s3fs]'") from exc
Review Comment:
```suggestion
raise NotInstalledError("AWS glue support not installed: pip install
'pyiceberg[glue]'") from exc
```
I see that how adding `s3fs` is convenient, but I think we should give the
user the choice to either install `pyarrow` or `s3fs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
