rdblue commented on code in PR #6233: URL: https://github.com/apache/iceberg/pull/6233#discussion_r1028476399
########## python/pyiceberg/table/__init__.py: ########## @@ -16,24 +16,43 @@ # under the License. from __future__ import annotations +from abc import ABC, abstractmethod +from dataclasses import dataclass +from functools import cache Review Comment: Moving these methods to the instance and using `lru_cache` caused lint failures: ``` python/pyiceberg/table/__init__.py:290:5: W1518: 'lru_cache(maxsize=None)' or 'cache' will keep all method args alive indefinitely, including 'self' (method-cache-max-size-none) ``` This was fixed if I use `lru_cache` but don't move the methods to instance methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
