lirui-apache commented on PR #6175:
URL: https://github.com/apache/iceberg/pull/6175#issuecomment-1324633275
It seems we generally agree to support pluggable cache. How about allow
users to specify ClientPool implementation class via a catalog property, and
HiveCatalog can instantiate ClientPool instance accordingly. We probably need
an `initialize` method in `ClientPool` so that catalogs can pass the
configurations, similar to the one in `Catalog` API. Something like this:
```java
/**
* Initialize the client pool with catalog properties and an optional
hadoop configuration.
*
* <p>A custom ClientPool implementation must have a no-arg constructor. A
Catalog using the ClientPool will first
* use this constructor to create an instance of the pool, and then call
this method to initialize the pool.
*
* @param properties catalog properties
* @param hadoopConf hadoop configuration
*/
default void initialize(Map<String, String> properties, Object hadoopConf)
{}
```
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
