ajantha-bhat commented on code in PR #6296:
URL: https://github.com/apache/iceberg/pull/6296#discussion_r1033776082
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java:
##########
@@ -356,6 +356,16 @@ public void testRewriteDataFilesWithInvalidInputs() {
+ "sort_order => 'c1 ASC NULLS FIRST')",
catalogName, tableIdent));
+ // Test for sort strategy without any (default/user defined) sort_order
+ AssertHelpers.assertThrows(
+ "Should reject calls with error message",
+ IllegalArgumentException.class,
+ "Can't use SORT when there is no sort order",
Review Comment:
This error message is present since the beginning of the sort strategy
support (maybe added by you :) ).
https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/actions/SortStrategy.java#L86
Do you strongly feel the need to change it now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
