stevenzwu commented on code in PR #6299:
URL: https://github.com/apache/iceberg/pull/6299#discussion_r1033979400
##########
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/assigner/SimpleSplitAssigner.java:
##########
@@ -51,7 +51,7 @@ public
SimpleSplitAssigner(Collection<IcebergSourceSplitState> assignerState) {
}
@Override
- public GetSplitResult getNext(@Nullable String hostname) {
+ public synchronized GetSplitResult getNext(@Nullable String hostname) {
Review Comment:
added `synchronized` because the new `pendingSplitCount` method can be
called from I/O threads, while other methods are only called from the
coordinator thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
