RussellSpitzer commented on code in PR #6309:
URL: https://github.com/apache/iceberg/pull/6309#discussion_r1035200849
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -213,40 +215,53 @@ public Scan build() {
Schema expectedSchema = schemaWithMetadataColumns();
- TableScan scan =
- table
- .newScan()
- .caseSensitive(caseSensitive)
- .filter(filterExpression())
- .project(expectedSchema);
+ if (startSnapshotId == null) {
+ BatchScan scan =
Review Comment:
Maybe this doesn't have to happen yet, but does it make sense to break out
some of this into some private helpers
```java
if (startingSnapshot) {
buildIncrementalScan()
return new SparkBatchQueryScan()
} else {
buildBatchScan()
return new SparkBatchQueryScan()
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
