rdblue commented on code in PR #6274:
URL: https://github.com/apache/iceberg/pull/6274#discussion_r1035417389
##########
core/src/main/java/org/apache/iceberg/LocationProviders.java:
##########
@@ -84,10 +84,7 @@ static class DefaultLocationProvider implements
LocationProvider {
private static String dataLocation(Map<String, String> properties, String
tableLocation) {
String dataLocation =
properties.get(TableProperties.WRITE_DATA_LOCATION);
if (dataLocation == null) {
- dataLocation =
properties.get(TableProperties.WRITE_FOLDER_STORAGE_LOCATION);
- if (dataLocation == null) {
- dataLocation = String.format("%s/data", tableLocation);
- }
+ dataLocation = String.format("%s/data", tableLocation);
Review Comment:
Why are we removing public-facing functionality like this? I don't think
that we should ever drop support for this because it will break existing tables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
