chenjunjiedada commented on PR #5967: URL: https://github.com/apache/iceberg/pull/5967#issuecomment-1333266198
>I don't think we should add a table identifier for the Flink job config, which should be common configs that applied to all Iceberg sources or sinks. For table specific config, they should stay as SQL hint options or passed in via the source/sink builder directly. Think this again, adding a table identifier looks too verbose and ugly consider it already can be set via SQL hint. Keeping/Limiting commons configs that apply to all iceberg sinks and sources for FlinkRead/WriteConf sounds reasonable to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
