stevenzwu commented on code in PR #6313:
URL: https://github.com/apache/iceberg/pull/6313#discussion_r1040425132
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkAppenderFactory.java:
##########
@@ -160,7 +184,8 @@ public EqualityDeleteWriter<RowData> newEqDeleteWriter(
eqDeleteRowSchema,
"Equality delete row schema shouldn't be null when creating
equality-delete writer");
- MetricsConfig metricsConfig = MetricsConfig.fromProperties(props);
+ MetricsConfig metricsConfig =
+ table != null ? MetricsConfig.forTable(table) :
MetricsConfig.fromProperties(props);
Review Comment:
this actually makes a stronger case that we should pass in a valid `Table`
object to the `FlinkAppenderFactory` as I mentioned in the other comment. we
should also use `forTable` for position delete although it doesn't need schema
or SortOrder as you said.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
