RussellSpitzer commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1042444111
##########
core/src/main/java/org/apache/iceberg/Partitioning.java:
##########
@@ -215,11 +225,12 @@ public Void alwaysNull(int fieldId, String sourceName,
int sourceId) {
* that have the same field ID but use a void transform under the hood. Such
fields cannot be part
* of the grouping key as void transforms always return null.
*
+ * @param schema a schema
Review Comment:
I think this needs a little more description as well as information about
what "null" means in this context. The Schema here is the projected schema to
pull transforms from?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
