szehon-ho commented on code in PR #6365:
URL: https://github.com/apache/iceberg/pull/6365#discussion_r1042557855
##########
core/src/main/java/org/apache/iceberg/BaseMetadataTable.java:
##########
@@ -64,9 +64,12 @@ protected BaseMetadataTable(TableOperations ops, Table
table, String name) {
*/
static PartitionSpec transformSpec(Schema metadataTableSchema, PartitionSpec
spec) {
PartitionSpec.Builder identitySpecBuilder =
- PartitionSpec.builderFor(metadataTableSchema).checkConflicts(false);
+ PartitionSpec.builderFor(metadataTableSchema)
Review Comment:
Before this change, predicate pushdown would make the PositionDeletes scan
tasks have wrong partition field id, spec id, so they will not work in the
DeleteFile read.
Though it only happens in corner cases like dropped partition fields (where
the auto-generated field-ids are not correct anymore). Added a test for this
in TestMetadataTableScansWithPartitionEvolution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
