stevenzwu commented on code in PR #6394:
URL: https://github.com/apache/iceberg/pull/6394#discussion_r1044646329


##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/IcebergTableSource.java:
##########
@@ -84,7 +84,7 @@ public IcebergTableSource(
       TableSchema schema,
       Map<String, String> properties,
       ReadableConfig readableConfig) {
-    this(loader, schema, properties, null, false, -1, ImmutableList.of(), 
readableConfig);
+    this(loader, schema, properties, null, false, null, ImmutableList.of(), 
readableConfig);

Review Comment:
   similar to the other comment. this doesn't seem right. it will also be 
inconsistent with the doc which said the default is `-1`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to