RussellSpitzer commented on code in PR #6350:
URL: https://github.com/apache/iceberg/pull/6350#discussion_r1044825312
##########
core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java:
##########
@@ -150,7 +150,7 @@ public static Iterable<Snapshot> ancestorsOf(long
snapshotId, Function<Long, Sna
/**
* Traverses the history of the table's current snapshot and finds the first
snapshot committed
- * after the given time.
+ * after the given time(inclusive).
Review Comment:
I'm not sure what Inclusive means in this context? Maybe we need to just
move his around to
"finds the oldest snapshot committed at or after the given snapshot"? I dunno
"finds the oldest snapshot that was committed either at or after a given
time"?
Or ignore me, I just always find the time docs difficult to understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
