nastra commented on code in PR #6246:
URL: https://github.com/apache/iceberg/pull/6246#discussion_r1044995887
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -112,6 +122,19 @@ public ThisT scanManifestsWith(ExecutorService
executorService) {
return self();
}
+ protected SnapshotMetrics snapshotMetrics() {
Review Comment:
I'm fine either way. I initially picked `SnapshotMetrics` over
`CommitMetrics` because I thought it would cause potential confusion with the
commit metrics in Flink, but I think it's less of an issue than I initially
thought. That being said, I've renamed everything to `CommitMetrics` /
`CommitReport`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
