rdblue commented on code in PR #6431:
URL: https://github.com/apache/iceberg/pull/6431#discussion_r1051678197
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestDictionaryRowGroupFilter.java:
##########
@@ -360,6 +362,21 @@ public void testNotNaNs() {
Assert.assertTrue("Should read: no_nans column will contain non-NaN",
shouldRead);
}
+ @Test
+ public void testNotNaNOnNaNsAndNulls() {
+ boolean shouldRead =
+ new ParquetDictionaryRowGroupFilter(SCHEMA, isNull("_nans_and_nulls"))
Review Comment:
Can you add cases for notNull and notNaN as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
