rdblue commented on code in PR #6432:
URL: https://github.com/apache/iceberg/pull/6432#discussion_r1051684443
##########
core/src/main/java/org/apache/iceberg/deletes/Deletes.java:
##########
@@ -144,7 +146,18 @@ public static <T extends StructLike> PositionDeleteIndex
toPositionIndex(
deletes ->
CloseableIterable.transform(
locationFilter.filter(deletes), row -> (Long)
POSITION_ACCESSOR.get(row)));
- return toPositionIndex(CloseableIterable.concat(positions));
+ return toPositionIndex(positions);
+ }
+
+ public static PositionDeleteIndex
toPositionIndex(List<CloseableIterable<Long>> positions) {
Review Comment:
Yes, I understand the purpose of the PR. Here, there should be a check so
that ParallelIterable is only used when there is more than one delete file to
read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
