ajantha-bhat commented on code in PR #6090:
URL: https://github.com/apache/iceberg/pull/6090#discussion_r1053500145
##########
core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java:
##########
@@ -1234,6 +1245,74 @@ public void
testMultipleRefsAndCleanExpiredFilesFailsForIncrementalCleanup() {
.commit());
}
+ @Test
+ public void testExpireWithStatisticsFiles() throws URISyntaxException,
IOException {
+ table.newAppend().appendFile(FILE_A).commit();
+ File statsFileLocation1 = statsFileLocation(table);
+ StatisticsFile statisticsFile1 = writeStatsFileForCurrentSnapshot(table,
statsFileLocation1);
+ Assert.assertEquals(
+ "Must match the latest snapshot",
+ table.currentSnapshot().snapshotId(),
+ statisticsFile1.snapshotId());
+
+ table.newAppend().appendFile(FILE_B).commit();
+ File statsFileLocation2 = statsFileLocation(table);
+ StatisticsFile statisticsFile2 = writeStatsFileForCurrentSnapshot(table,
statsFileLocation2);
+ Assert.assertEquals(
+ "Must match the latest snapshot",
+ table.currentSnapshot().snapshotId(),
+ statisticsFile2.snapshotId());
+
+ Assert.assertEquals("Should have 2 statistics file", 2,
table.statisticsFiles().size());
+
+ table.updateProperties().set(TableProperties.MAX_SNAPSHOT_AGE_MS,
"1").commit();
Review Comment:
The testcase in this file has the same pattern. I will modify this one first
and then have a follow up to fix the existing testcases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
