aokolnychyi commented on code in PR #6371:
URL: https://github.com/apache/iceberg/pull/6371#discussion_r1053558520
##########
core/src/main/java/org/apache/iceberg/Partitioning.java:
##########
@@ -200,6 +200,16 @@ public Void alwaysNull(int fieldId, String sourceName, int
sourceId) {
/**
* Builds a grouping key type considering all provided specs.
*
+ * @param specs one or many specs
+ * @return the constructed grouping key type
+ */
+ public static StructType groupingKeyType(Collection<PartitionSpec> specs) {
Review Comment:
We could, I wasn't sure. If you have a set of specs, we probably have a
schema too. I'll deprecate.
##########
core/src/main/java/org/apache/iceberg/Partitioning.java:
##########
@@ -200,6 +200,16 @@ public Void alwaysNull(int fieldId, String sourceName, int
sourceId) {
/**
* Builds a grouping key type considering all provided specs.
*
+ * @param specs one or many specs
+ * @return the constructed grouping key type
+ */
+ public static StructType groupingKeyType(Collection<PartitionSpec> specs) {
Review Comment:
We could, I wasn't sure. If you have a set of specs, you probably have a
schema too. I'll deprecate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
