hililiwei commented on PR #6222:
URL: https://github.com/apache/iceberg/pull/6222#issuecomment-1360903987
> like to get more feedback for adding a new public method in the api
module. cc @rdblue @aokolnychyi @RussellSpitzer @szehon-ho
>
> Here is the context why we need this. The converter in `FlinkSchemaUtil`
creates Iceberg `Schema` without doc attributes. Hence @hililiwei implemented
the util class and method to carry over the doc attribute from
`docSourceSchema` to `schema` (converted from Flink `TableSchema`).
>
> ```
> public static Schema convert(TableSchema schema) {
> }
> ```
>
> I suggested moving it into `TypeUtil` class in api module as it is very
similar to the `reassignIds` method in the `TypeUtil` class.
cc @rdblue @aokolnychyi @RussellSpitzer @szehon-ho
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
