amogh-jahagirdar commented on code in PR #6565: URL: https://github.com/apache/iceberg/pull/6565#discussion_r1067231261
########## core/src/test/java/org/apache/iceberg/view/ParserTestBase.java: ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.view; + +import java.io.IOException; +import java.nio.file.Path; +import java.nio.file.Paths; +import org.apache.iceberg.util.JsonUtil; +import org.apache.iceberg.util.TestJsonUtil; +import org.junit.Assert; +import org.junit.Test; + +public abstract class ParserTestBase<T> { + + private final T entry; + private final String json; + private final JsonUtil.JsonWriter<T> writer; + private final JsonUtil.JsonReader<T> reader; + + public ParserTestBase( Review Comment: Agreed, I think what we can do is just follow the existing pattern for testing table metadata and just enumerate different toJson/fromJson cases. While the benefit of having a parent class is to reduce some duplication, for the parsing code it seems better just to have more explicit tests (for example like we do with ref parser) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
