amogh-jahagirdar commented on code in PR #5234:
URL: https://github.com/apache/iceberg/pull/5234#discussion_r1067501650
##########
core/src/test/java/org/apache/iceberg/TestRowDelta.java:
##########
@@ -1270,11 +1332,16 @@ public void
testConcurrentNonConflictingRowDeltaAndRewriteFilesWithSequenceNumbe
baseSnapshot.sequenceNumber())
.validateFromSnapshot(baseSnapshot.snapshotId());
- rowDelta.commit();
- rewriteFiles.commit();
+ commit(table, rowDelta, branch);
+ commit(table, rewriteFiles, branch);
- validateTableDeleteFiles(table, deleteFile1);
- validateTableFiles(table, dataFile2);
+ if (branch == "testBranch") {
Review Comment:
Also just realized we don't need to differentiate the two cases here, I
think we could just have a single method which takes in a branch (and the
branch could just be main or not, it doesn't really matter)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
