Fokko commented on code in PR #6525:
URL: https://github.com/apache/iceberg/pull/6525#discussion_r1068116008
##########
python/pyiceberg/typedef.py:
##########
@@ -79,6 +84,10 @@ def __missing__(self, key: K) -> V:
class StructProtocol(Protocol): # pragma: no cover
"""A generic protocol used by accessors to get and set at positions of an
object"""
+ @abstractmethod
+ def set_record_schema(self, record_schema: StructType) -> None:
Review Comment:
I've merged the two records into one now. Changing the schema makes things
more complicated. For example, then we should also unset fields, which we can
do, but we make it more complex. For the sake of keeping things simple, we
could limit the reuse of the record within the StructReader, and this way it
always reads the same schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
