rdblue commented on code in PR #2639:
URL: https://github.com/apache/iceberg/pull/2639#discussion_r1071456708


##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -1000,6 +1064,19 @@ public ReadBuilder withNameMapping(NameMapping 
newNameMapping) {
       return this;
     }
 
+    private FileDecryptionProperties createDecryptionProperties(
+        NativeFileCryptoParameters nativeParameters) {
+      Preconditions.checkArgument(nativeParameters != null, "Null native 
crypto parameters");
+
+      ByteBuffer footerDataKey = nativeParameters.fileKey();
+      if (null == footerDataKey) {
+        throw new ParquetCryptoRuntimeException(
+            "Can't create parquet decryption properties - " + "missing key for 
parquet footer");
+      }
+
+      return 
FileDecryptionProperties.builder().withFooterKey(footerDataKey.array()).build();

Review Comment:
   Our initial version should support a file encryption key and AAD.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to