namrathamyske commented on code in PR #5234:
URL: https://github.com/apache/iceberg/pull/5234#discussion_r1073044093
##########
core/src/test/java/org/apache/iceberg/TableTestBase.java:
##########
@@ -472,6 +484,20 @@ void validateTableDeleteFiles(Table tbl, DeleteFile...
expectedFiles) {
Assert.assertEquals("Delete files should match", expectedFilePaths,
actualFilePaths);
}
+ void validateBranchDeleteFiles(Table tbl, String branch, DeleteFile...
expectedFiles) {
+ Set<CharSequence> expectedFilePaths = Sets.newHashSet();
+ for (DeleteFile file : expectedFiles) {
+ expectedFilePaths.add(file.path());
+ }
+ Set<CharSequence> actualFilePaths = Sets.newHashSet();
+ for (FileScanTask task : tbl.newScan().useRef(branch).planFiles()) {
+ for (DeleteFile file : task.deletes()) {
+ actualFilePaths.add(file.path());
+ }
+ }
+ Assert.assertEquals("Delete files should match", expectedFilePaths,
actualFilePaths);
+ }
Review Comment:
Will go ahead edit the whole class too.
##########
core/src/test/java/org/apache/iceberg/TableTestBase.java:
##########
@@ -472,6 +484,20 @@ void validateTableDeleteFiles(Table tbl, DeleteFile...
expectedFiles) {
Assert.assertEquals("Delete files should match", expectedFilePaths,
actualFilePaths);
}
+ void validateBranchDeleteFiles(Table tbl, String branch, DeleteFile...
expectedFiles) {
+ Set<CharSequence> expectedFilePaths = Sets.newHashSet();
+ for (DeleteFile file : expectedFiles) {
+ expectedFilePaths.add(file.path());
+ }
+ Set<CharSequence> actualFilePaths = Sets.newHashSet();
+ for (FileScanTask task : tbl.newScan().useRef(branch).planFiles()) {
+ for (DeleteFile file : task.deletes()) {
+ actualFilePaths.add(file.path());
+ }
+ }
+ Assert.assertEquals("Delete files should match", expectedFilePaths,
actualFilePaths);
+ }
Review Comment:
Will go ahead edit the whole test class too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
