nastra commented on PR #6474: URL: https://github.com/apache/iceberg/pull/6474#issuecomment-1397047250
> BTW, I am the library's user more frequently than its contributor. As a user, I would benefit from explicit indication which API methods accept nulls, and even more -- which can return nulls. We keep asking "can this be null" question in PR reviews (eg here [trinodb/trino#14869 (comment)](https://github.com/trinodb/trino/pull/14869#discussion_r1072388756)) but more often than not, we _forget_ to ask that question, potentially setting us to NPE failures. > > This too, I would prefer to be a follow up, not a prerequisite for a merge here. I agree that it would improve things when it's more obvious that certain things can/cannot be null, e.g. through `@Nullable`. Maybe this is something we should mention on the ML to raise awareness? Re: cNN vs cA I think it's fine to go ahead and get this merged with what you prefer (assuming the error message is updated as mentioned above) as we don't want to block things from getting in while this is discussed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
