aokolnychyi commented on code in PR #6365:
URL: https://github.com/apache/iceberg/pull/6365#discussion_r1083087907
##########
core/src/main/java/org/apache/iceberg/BaseMetadataTable.java:
##########
@@ -73,9 +73,12 @@ protected BaseMetadataTable(Table table, String name) {
*/
static PartitionSpec transformSpec(Schema metadataTableSchema, PartitionSpec
spec) {
PartitionSpec.Builder identitySpecBuilder =
- PartitionSpec.builderFor(metadataTableSchema).checkConflicts(false);
+ PartitionSpec.builderFor(metadataTableSchema)
+ .withSpecId(spec.specId())
+ .checkConflicts(false);
for (PartitionField field : spec.fields()) {
Review Comment:
nit: What about adding empty lines before and after this loop? Also, I'd
consider renaming the builder variable to make it shorter and stay on one line.
##########
core/src/main/java/org/apache/iceberg/BaseMetadataTable.java:
##########
@@ -73,9 +73,12 @@ protected BaseMetadataTable(Table table, String name) {
*/
static PartitionSpec transformSpec(Schema metadataTableSchema, PartitionSpec
spec) {
PartitionSpec.Builder identitySpecBuilder =
- PartitionSpec.builderFor(metadataTableSchema).checkConflicts(false);
+ PartitionSpec.builderFor(metadataTableSchema)
+ .withSpecId(spec.specId())
+ .checkConflicts(false);
for (PartitionField field : spec.fields()) {
Review Comment:
nit: What about adding empty lines before and after this loop? Also, I'd
consider renaming the builder variable to make it shorter and stay on one line.
Up to you, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
