jackye1995 commented on code in PR #6624:
URL: https://github.com/apache/iceberg/pull/6624#discussion_r1083331517
##########
api/src/main/java/org/apache/iceberg/actions/MigrateTable.java:
##########
@@ -50,6 +50,15 @@ default MigrateTable dropBackup() {
throw new UnsupportedOperationException("Dropping a backup is not
supported");
}
+ /**
+ * @param numReaders the number of concurrent file read operations to use
per partition
+ * @return this for method chaining
+ */
+ default MigrateTable withParallelReads(int numReaders) {
Review Comment:
Thanks, I see there are 2 places I think can be consistent, the first is
this place, where we can just do `default MigrateTable withParallelism(int
parallelism)` instead of using a different name and introduce a `reader`
concept.
The other place is in the procedure, where you have `
ProcedureParameter.optional("max_concurrent_read_datafiles",
DataTypes.IntegerType)
`, we can just name the option `parallelism` as well.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
