Fokko commented on code in PR #6590:
URL: https://github.com/apache/iceberg/pull/6590#discussion_r1083538914
##########
python/pyiceberg/io/pyarrow.py:
##########
@@ -470,6 +472,59 @@ def expression_to_pyarrow(expr: BooleanExpression) ->
pc.Expression:
return boolean_expression_visit(expr, _ConvertToArrowExpression())
+def open_task(
+ task: FileScanTask,
+ fs: FileSystem,
+ table: Table,
+ row_filter: BooleanExpression,
+ projected_schema: Schema,
+ case_sensitive: bool,
+) -> pa.Table:
+ _, path = PyArrowFileIO.parse_location(task.file.file_path)
+
+ bound_row_filter = bind(table.schema(), row_filter,
case_sensitive=case_sensitive)
Review Comment:
I think we can bind this once to the table before fanning out. We can just
pass in the `bound_row_filter` since this one will be the same for each of the
tables (will also be easier on the GIL).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
