rdblue commented on code in PR #6474:
URL: https://github.com/apache/iceberg/pull/6474#discussion_r1083574777
##########
core/src/main/java/org/apache/iceberg/BaseTable.java:
##########
@@ -48,6 +49,7 @@ public BaseTable(TableOperations ops, String name) {
}
public BaseTable(TableOperations ops, String name, MetricsReporter reporter)
{
+ Preconditions.checkNotNull(reporter, "reporter cannot be null");
Review Comment:
+1 for @nastra's comment about the error message.
Whether we use `checkNotNull` or `checkArgument` doesn't really matter
because both are `ArgumentException`. The problem with this is that it makes an
unnecessary change to have an error message that doesn't fit with the
conventions used elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
