pvary commented on code in PR #6570:
URL: https://github.com/apache/iceberg/pull/6570#discussion_r1083871753
##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -303,6 +303,9 @@ private TableProperties() {}
public static final String ENGINE_HIVE_ENABLED = "engine.hive.enabled";
public static final boolean ENGINE_HIVE_ENABLED_DEFAULT = false;
+ public static final String LOCK_HIVE_ENABLED = "lock.hive.enabled";
Review Comment:
> Thanks for these efforts @pvary . I left some comments. I think it would
be easier to review if we just did the refactor first, then the changes are
more minimal for supporting the new NoLock mechanism, which I havent wrapped my
mind around fully yet.
Thanks for the review!
Separated the lock refactor to a different PR: #6648, and after it is
merged, we can go through the `NoLock` change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
