rdblue commented on code in PR #6616:
URL: https://github.com/apache/iceberg/pull/6616#discussion_r1084233763
##########
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java:
##########
@@ -622,7 +636,11 @@ private static AuthSession fromTokenResponse(
String credential) {
AuthSession session =
new AuthSession(
- parent.headers(), response.token(), response.issuedTokenType(),
credential);
+ parent.headers(),
+ response.token(),
+ response.issuedTokenType(),
+ credential,
+ parent.scope());
Review Comment:
When this is called in `fromTokenExchange`, the scope passed there is not
passed in here. I think that this method needs to have a `scope` argument. Then
the `fromTokenResponse` above can pass `parent.scope()` and `fromTokenExchange`
can pass the scope it was passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
