amogh-jahagirdar commented on code in PR #6651:
URL: https://github.com/apache/iceberg/pull/6651#discussion_r1086039687
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java:
##########
@@ -247,6 +248,11 @@ public ScanBuilder newScanBuilder(CaseInsensitiveStringMap
options) {
@Override
public WriteBuilder newWriteBuilder(LogicalWriteInfo info) {
+ boolean branchOptionPresent =
info.options().containsKey(SparkWriteOptions.BRANCH);
+ if (!branchOptionPresent) {
+ Preconditions.checkArgument(
+ snapshotId == null, "Cannot write to table at a specific snapshot:
%s", snapshotId);
+ }
Review Comment:
I'll need to double check the code in case there's any other implications to
this but in case we do go this route could we combine the boolean and
precondition check
```
boolean branchWrite = info.options().containsKey(SparkWriteOptions.BRANCH);
Preconditions.checkArgument(branchWrite || snapshotId == null, "Cannot write
to table at a specific snapshot: %s", snapshotId)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
