RussellSpitzer commented on code in PR #6624:
URL: https://github.com/apache/iceberg/pull/6624#discussion_r1087967571
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/procedures/AddFilesProcedure.java:
##########
@@ -119,8 +120,15 @@ public InternalRow[] call(InternalRow args) {
checkDuplicateFiles = args.getBoolean(3);
}
+ int parallelism;
Review Comment:
I'm not sure how we ended up with this pattern here, in the other procedures
we do
```java
var = (arg.nullat(?)) default : arg.get(?);
```
Although There is probably no reason to change this now. I do think a
default of 1 is still probably too low. I feel like this is a `gotcha` default
and is basically never correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
