nastra commented on code in PR #6169:
URL: https://github.com/apache/iceberg/pull/6169#discussion_r1093810144
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -1119,6 +1139,54 @@ public <T extends S3ClientBuilder> void
applyS3ServiceConfigurations(T builder)
.build());
}
+ /**
+ * Configure a signer for an S3 client.
+ *
+ * <p>Sample usage:
+ *
+ * <pre>
+ *
S3Client.builder().applyMutation(awsProperties::applyS3SignerConfiguration)
+ * </pre>
+ */
+ public <T extends S3ClientBuilder> void applyS3SignerConfiguration(T
builder) {
+ if (null != s3SignerImpl) {
+ builder.overrideConfiguration(
+ c -> c.putAdvancedOption(SdkAdvancedClientOption.SIGNER,
loadS3SignerDynamically()));
+ }
+ }
+
+ @SuppressWarnings("checkstyle:NestedTryDepth")
+ private Signer loadS3SignerDynamically() {
+ // load the signer implementation dynamically
+ Object signer;
+ try {
+ signer =
+ DynMethods.builder("create")
+ .impl(s3SignerImpl, Map.class)
+ .buildStaticChecked()
+ .invoke(allProperties);
+ } catch (NoSuchMethodException e) {
Review Comment:
I've removed the nesting and added logging as you suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
