rdblue commented on code in PR #6622:
URL: https://github.com/apache/iceberg/pull/6622#discussion_r1094779610
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkReadOptions.java:
##########
@@ -90,4 +90,6 @@ private SparkReadOptions() {}
public static final String VERSION_AS_OF = "versionAsOf";
public static final String TIMESTAMP_AS_OF = "timestampAsOf";
+
+ public static final String AGGREGATE_PUSH_DOWN_ENABLED =
"aggregatePushDownEnabled";
Review Comment:
Iceberg uses properties that are words separated by `-`. The reason why the
two above use camelCase instead is that they are standard options used by
Spark. I think for this we should use `aggregate-push-down-enabled`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
