aokolnychyi commented on code in PR #6682:
URL: https://github.com/apache/iceberg/pull/6682#discussion_r1095231341
##########
api/src/main/java/org/apache/iceberg/actions/DeleteOrphanFiles.java:
##########
@@ -67,7 +67,11 @@ public interface DeleteOrphanFiles extends
Action<DeleteOrphanFiles, DeleteOrpha
*
* @param deleteFunc a function that will be called to delete files
* @return this for method chaining
+ * @deprecated Deletes are now performed in bulk see {@link
#deleteBulkWith(Consumer)}. This
Review Comment:
An empty delete function is also used for dry runs to analyze candidates
prior to their physical removal. We can also collect go the data frame route
but we offer `deleteWith` in a number of APIs, so I don't see a big problem.
> For example, if I have multiple actions running at the same time, the
coordination of requests to S3 or whatnot should happen at the FileIO,
otherwise the user needs to manually be determining the correct values for each
of their possible concurrent jobs.
We should have a way to configure this global default in `FileIO` and it is
a correct place to do it. My point is that I don't see harm allowing certain
operations to override that default, especially if it makes the implementation
simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
