singhpk234 commented on code in PR #6655:
URL: https://github.com/apache/iceberg/pull/6655#discussion_r1096212430
##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -168,6 +168,10 @@ private static String implFromLocation(String location) {
return SCHEME_TO_FILE_IO.getOrDefault(scheme(location), FALLBACK_IMPL);
}
+ public Class<? extends FileIO> ioClass(String location) {
+ return io(location).getClass();
Review Comment:
we also wanted to check if any fileIO extending HadoopFileIO should also be
covered hence didn't use the implFromFileLocation, but definitely loading
S3FileIO etc is going to be expensive, was thinking we would eventually need
the fileIO obj anyway since we check the table location at the moment (unless
the location of metadata and data path are overidden by table prop), Should we
restrict the check to only HadoopFileIO, Your thoughs ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
