gaborkaszab commented on code in PR #6661:
URL: https://github.com/apache/iceberg/pull/6661#discussion_r1097102496
##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -47,7 +48,11 @@ public class PartitionsTable extends BaseMetadataTable {
Types.NestedField.required(1, "partition",
Partitioning.partitionType(table)),
Types.NestedField.required(2, "record_count",
Types.LongType.get()),
Review Comment:
Wouldn't it be a breaking change? If someone already has a client that
expects the field names 'record_count' and 'file_count' then it would break
between minor Iceberg releases. I think changes like this should happen in a
major release and before that we might want to mark these fields as deprecated
while also introducing the ones with the new names.
I'm open for opinions from others, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
