rdblue commented on code in PR #6746:
URL: https://github.com/apache/iceberg/pull/6746#discussion_r1097905950


##########
core/src/main/java/org/apache/iceberg/util/PropertyUtil.java:
##########
@@ -120,6 +120,27 @@ public static Map<String, String> propertiesWithPrefix(
         .collect(Collectors.toMap(e -> e.getKey().replaceFirst(prefix, ""), 
Map.Entry::getValue));
   }
 
+  /**
+   * Returns subset of provided map with keys matching the provided prefix. 
Matching is
+   * case-sensitive.
+   *
+   * @param properties input map
+   * @param prefix prefix to choose keys from input map
+   * @return subset of input map with keys starting with provided prefix
+   */
+  public static Map<String, String> propertiesWithPrefixNoTrim(

Review Comment:
   "Trim" typically means removing whitespace. Is there a better way to name 
this method? Maybe the `startsWith` could be passed as a `Predicate<String>`  
and this could be `filterProperties`? Or maybe `filterPropertiesByPrefix`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to