amogh-jahagirdar commented on code in PR #6752:
URL: https://github.com/apache/iceberg/pull/6752#discussion_r1098226674
##########
spark/v3.3/spark-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4:
##########
@@ -74,6 +74,7 @@ statement
| ALTER TABLE multipartIdentifier SET IDENTIFIER_KW FIELDS fieldList
#setIdentifierFields
| ALTER TABLE multipartIdentifier DROP IDENTIFIER_KW FIELDS fieldList
#dropIdentifierFields
| ALTER TABLE multipartIdentifier createReplaceBranchClause
#createOrReplaceBranch
+ | ALTER TABLE multipartIdentifier DROP BRANCH identifier #dropBranch
Review Comment:
I think it's how the diff is rendered
https://github.com/apache/iceberg/blob/master/spark/v3.3/spark-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4#L74
setIdentifier/call and the others are all on the same row, so i'm leaving as
is to be consistent. let me know if you have any doubts!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
