wypoon commented on code in PR #5893:
URL: https://github.com/apache/iceberg/pull/5893#discussion_r1102203696
##########
core/src/test/java/org/apache/iceberg/TableTestBase.java:
##########
@@ -237,12 +253,23 @@ ManifestFile writeManifest(DataFile... files) throws
IOException {
}
ManifestFile writeManifest(Long snapshotId, DataFile... files) throws
IOException {
- File manifestFile = temp.newFile("input.m0.avro");
Review Comment:
Yes, we do need the manifest file to end in ".avro", but it's fine to call
`temp.newFile()` (which uses a random name) and add the extension afterwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
