jackye1995 commented on code in PR #6717:
URL: https://github.com/apache/iceberg/pull/6717#discussion_r1103757921
##########
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/source/TestSnapshotSelection.java:
##########
@@ -368,6 +370,64 @@ public void
testSnapshotSelectionByTimestampAndBranchOrTagFails() throws IOExcep
.load(tableLocation)
.show())
.isInstanceOf(IllegalArgumentException.class)
- .hasMessageStartingWith("Cannot override ref, already set snapshot
id=");
+ .hasMessageStartingWith("Can specify at most one of snapshot-id");
+ }
+
+ @Test
+ public void testSnapshotSelectionByBranchOrTagWithSchemaChange() throws
IOException {
Review Comment:
can we have separated tests for branch and tag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
