nastra commented on code in PR #6801:
URL: https://github.com/apache/iceberg/pull/6801#discussion_r1105479752
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java:
##########
@@ -69,7 +69,7 @@ public void testZOrderSortExpression() {
public void testRewriteDataFilesInEmptyTable() {
createTable();
List<Object[]> output = sql("CALL %s.system.rewrite_data_files('%s')",
catalogName, tableIdent);
- assertEquals("Procedure output must match", ImmutableList.of(row(0, 0)),
output);
+ assertEquals("Procedure output must match", ImmutableList.of(row(0, 0,
0L)), output);
Review Comment:
I've updated checks to compare results with programmatically determined file
sizes
##########
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##########
@@ -159,6 +160,7 @@ public void testBinPackUnpartitionedTable() {
Result result = basicRewrite(table).execute();
Assert.assertEquals("Action should rewrite 4 data files", 4,
result.rewrittenDataFilesCount());
Assert.assertEquals("Action should add 1 data file", 1,
result.addedDataFilesCount());
+ assertThat(result.rewrittenBytesCount()).isGreaterThan(0L);
Review Comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
