szehon-ho commented on PR #6797: URL: https://github.com/apache/iceberg/pull/6797#issuecomment-1430209452
I was initially thinking, we could have had SparkTableUtil.importPartitions return the number of changed partitions (and number added data files for that matter). But then we'd have to change the public API for return type, which means add a new one, and is ugly. Not sure its worth it for now. > Shall we update the docs inline or somewhere on public facing documents such as https://github.com/apache/iceberg/blob/694bc3038bcf2c8e5c4053fc31a5c784c9366da3/docs/spark-procedures.md#add_files? I think we can put it in the public docs in separate pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
