wypoon commented on code in PR #6799:
URL: https://github.com/apache/iceberg/pull/6799#discussion_r1106574636
##########
core/src/main/java/org/apache/iceberg/ManifestListWriter.java:
##########
@@ -31,14 +31,18 @@
abstract class ManifestListWriter implements FileAppender<ManifestFile> {
private final FileAppender<ManifestFile> writer;
- private ManifestListWriter(OutputFile file, Map<String, String> meta) {
- this.writer = newAppender(file, meta);
+ private ManifestListWriter(
+ OutputFile file,
+ Map<String, String> meta,
+ String compressionCodec,
+ Integer compressionLevel) {
+ this.writer = newAppender(file, meta, compressionCodec, compressionLevel);
}
protected abstract ManifestFile prepare(ManifestFile manifest);
protected abstract FileAppender<ManifestFile> newAppender(
- OutputFile file, Map<String, String> meta);
+ OutputFile file, Map<String, String> meta, String compressionCodec,
Integer compressionLevel);
Review Comment:
This is not what's causing the revapi breakage; it is the `newAppender` in
`ManifestWriter`.
`ManifestListWriter` is package private, not public, so the change is not an
API break.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
