ajantha-bhat commented on code in PR #6834:
URL: https://github.com/apache/iceberg/pull/6834#discussion_r1106689940
##########
data/src/main/java/org/apache/iceberg/data/IcebergGenerics.java:
##########
@@ -66,6 +67,11 @@ public ScanBuilder select(String... selectedColumns) {
return this;
}
+ public ScanBuilder select(Collection<String> columns) {
+ this.tableScan = tableScan.select(ImmutableList.copyOf(columns));
Review Comment:
they may want to convert arrays into a collection and use the collection
interface. But that is also not needed now as the underlying interface has a
conversion logic.
https://github.com/apache/iceberg/blob/634215fcd411dd8a6d5c0b6d7d8dbf4eb66494d8/api/src/main/java/org/apache/iceberg/Scan.java#L96-L98
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
